W-22203426: feat: promote agent test run-eval to GA and delegate logic to @salesforce/agents#413
Open
andresrivas-sf wants to merge 3 commits intomainfrom
Open
W-22203426: feat: promote agent test run-eval to GA and delegate logic to @salesforce/agents#413andresrivas-sf wants to merge 3 commits intomainfrom
andresrivas-sf wants to merge 3 commits intomainfrom
Conversation
…o @salesforce/agents W-22203426 Removes local copies of evalNormalizer, evalFormatter, and yamlSpecTranslator now that they live in the shared library. Rewrites run-eval.ts as a thin CLI shell that imports normalizePayload, translateTestSpec, resolveAgent, executeBatches, buildResultSummary, and formatResults from @salesforce/agents. Promotes the command from state='beta'/hidden to state='ga'. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Remove state='ga' (GA commands omit state to avoid oclif help regression) - Remove unused --wait flag - Wrap parseTestSpec/translateTestSpec in try/catch for named SfError - Validate test.steps is an array before injection loop - Hoist isYamlTestSpec to avoid double-call - Extract resolveAndInjectAgent helper to stay within complexity limit - Fix test stubs to use $$.SANDBOX, remove sinon.restore(), fix describe label Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…emoval Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@W-22203426@
evalNormalizer.ts,evalFormatter.ts, andyamlSpecTranslator.ts— these now live in@salesforce/agentsrun-eval.tsas a thin CLI shell that importsnormalizePayload,translateTestSpec,resolveAgent,executeBatches,buildResultSummary, andformatResultsfrom@salesforce/agentsstate='beta'/hidden tostate='ga'esmockto mock@salesforce/agentsDepends on: forcedotcom/agents#276 being merged and version bumped before this can be fully consumed from npm. Local development uses
yarn link "@salesforce/agents".Test plan
yarn compilepassesyarn testpasses including the newtest/commands/agent/test/run-eval.test.tssf agent test run-eval --helpshows the command without(beta)label🤖 Generated with Claude Code